I have acquired over time a collection of batter operated tools, drills, impact wrench, sawzall etc.

I don't use them often, is it better to store the batteries in a charger and keep them topped off or just keep them in my tool bag and charge them when I need them?

I would charge them and put them in the bag or case with the tool. If stored long term you will need to charge before use anyways.